Fix admin console service ports & tls secret name location #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error coming from circleci isn't very decriptive. |
| @@ -1576,10 +1576,10 @@ pulsarAdminConsole: | |||
| type: LoadBalancer | |||
| ports: | |||
| - name: http | |||
| port: 80 | |||
| port: 8080 | |||
There was a problem hiding this comment.
Since these endpoints are meant to be hit by a browser, we want to use the standard ports 80 and 443. Otherwise, users would need to configure the port when logging into the Pulsar Admin Console.
There was a problem hiding this comment.
I had the ingress taking care of this. I take it the intent was to open directly.
| @@ -70,7 +70,8 @@ spec: | |||
| tls: | |||
| - hosts: | |||
| - {{ .Values.pulsarAdminConsole.ingress.host }} | |||
| secretName: {{ .Values.tlsSecretName }} | |||
| secretName: "{{ .Values.tls.pulsarAdminConsole.tlsSecretName }}" | |||
There was a problem hiding this comment.
To ensure backward compatibility, I think we actually want this:
Suggested change
| secretName: "{{ .Values.tls.pulsarAdminConsole.tlsSecretName }}" | |
| secretName: {{ .Values.tls.pulsarAdminConsole.tlsSecretName | default .Values.tlsSecretName | quote }} |
There was a problem hiding this comment.
Being that tlsSecretName is deprecated I didn't want to continue its use.
pgier
pushed a commit
to pgier/datastax-pulsar-helm-chart
that referenced
this pull request
Jul 13, 2022
- The log collection failed after a command failed. - tolerate errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.