Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls section to ingress manifest #218

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ddieruf
Copy link
Contributor

@ddieruf ddieruf commented May 28, 2022

No description provided.

Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddieruf - what is the motivation for this PR?

I don't think this TLS configuration would work correctly, since the top level tls key is used to configure an ingress controller, like nginx, to terminate TLS. When enableTls is true, TLS is currently configured to terminate at the proxy.

@ddieruf
Copy link
Contributor Author

ddieruf commented Jun 1, 2022

That was my intention with adding the tls section to the ingress. I wanted it to terminate there. Is there another ingress created somewhere for the proxy?

The current file has no tls section and the spacing for path: /broker is broken.

@michaeljmarshall
Copy link
Member

@ddieruf - you're correct that the indentation is wrong in that file.

That was my intention with adding the tls section to the ingress. I wanted it to terminate there. Is there another ingress created somewhere for the proxy?

Can you clarify this point? Where do you want it to terminate? Also, have you tested this change to verify that it adds the support you'd like to see? Thanks!

@ddieruf
Copy link
Contributor Author

ddieruf commented Jun 8, 2022

I am running this in my home lab, where I don't have a proper device to terminate TLS or load balance. I was only running 1 instance of the proxy and wanted to use the tls feature of the ingress to handle things.

Maybe I am going about this wrong. I had envisioned tls requests coming into the proxy, then the proxy forwarding on to the broker. I am not using inter-component tls, so the proxy terminates.

I have this running but have other compatibility issues with the way Let's Encrypt sends cert data to cert-manager. They include the CA in the cert chain and don't break it out. Thus, cert-manager only creates the certstore not the truststore. So my proxy is not healthy ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants