Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #3

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Fix tests #3

merged 3 commits into from
Sep 10, 2024

Conversation

PeterKraus
Copy link
Contributor

Since we now have galvani and yadg in yard, the tests were actually installing galvani for most cases. Fix tests by:

  • adding xarray-datatree to [formats], since it's needed by yadg>=5.1 (this is temporary and won't be needed once Datatree is in parent xarray
  • add more logic to extract() so that preferred_mode is matched

This means for cli tests the mpr test suite runs with yadg and for python tests it runs with galvani.

@PeterKraus PeterKraus mentioned this pull request Sep 10, 2024
Merged
ml-evs
ml-evs approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- we should think about how extractors can report their desired formats at some point (thinking e.g. if we'll have issues with pandas 3 etc)

@ml-evs ml-evs merged commit 1a8cc30 into main Sep 10, 2024
6 checks passed
@PeterKraus PeterKraus mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@davidelbert davidelbert Awaiting requested review from davidelbert davidelbert is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterKraus @ml-evs