Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/room-history-view #66

Merged
merged 52 commits into from
Apr 3, 2024
Merged

feat/room-history-view #66

merged 52 commits into from
Apr 3, 2024

Conversation

MAXOUXAX
Copy link
Contributor

No description provided.

@MAXOUXAX MAXOUXAX added feature Issues that plan on adding features backend Backend related issues frontend Frontend related issues labels Jan 22, 2024
@MAXOUXAX MAXOUXAX added this to the Itération 3 milestone Jan 22, 2024
@MAXOUXAX MAXOUXAX self-assigned this Jan 22, 2024
GaspardBBY
GaspardBBY reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@GaspardBBY GaspardBBY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is beautiful, keep it up

expo/components/RoomHistory.tsx Outdated Show resolved Hide resolved
TheRealSharKzy
TheRealSharKzy reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@TheRealSharKzy TheRealSharKzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if my reviews are really relevant, but overall it seems good

backend/src/route/RoomGET.ts Outdated Show resolved Hide resolved
expo/components/RoomHistory.tsx Outdated Show resolved Hide resolved
@MAXOUXAX MAXOUXAX force-pushed the feat/room-history-view branch from 852c9d2 to 4b06d03 Compare January 24, 2024 08:33
@MAXOUXAX MAXOUXAX force-pushed the feat/room-history-view branch 2 times, most recently from 3f94301 to cc63c39 Compare January 25, 2024 08:16
@MAXOUXAX MAXOUXAX modified the milestones: Itération 3, Itération 4 Jan 27, 2024
TheRealSharKzy
TheRealSharKzy suggested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@TheRealSharKzy TheRealSharKzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good, 2 minor changes I think

expo/components/RoomHistory.tsx Show resolved Hide resolved
expo/components/RoomHistory.tsx Outdated Show resolved Hide resolved
@MAXOUXAX MAXOUXAX force-pushed the feat/room-history-view branch from cc63c39 to c45d64a Compare January 30, 2024 07:52
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
datsmysong ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2024 10:58am

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 30, 2024
View reviewed changes
backend/src/route/RoomGET.ts Fixed Show fixed Hide fixed
backend/src/route/RoomGET.ts Fixed Show fixed Hide fixed
backend/src/route/RoomGET.ts Fixed Show fixed Hide fixed
expo/components/RoomHistory.tsx Fixed Show fixed Hide fixed
@MAXOUXAX MAXOUXAX linked an issue Feb 6, 2024 that may be closed by this pull request
Consulter l’historique et les détails d’une salle d’écoute passée #12
Closed
@MAXOUXAX MAXOUXAX modified the milestones: Itération 4, Itération 5 Feb 13, 2024
MAXOUXAX
MAXOUXAX commented Feb 14, 2024
View reviewed changes
Copy link
Contributor Author

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes but on a good path

backend/src/route/InactiveRoomUserIdGET.ts Outdated Show resolved Hide resolved
backend/src/route/RoomGET.ts Outdated Show resolved Hide resolved
backend/src/server.ts Outdated Show resolved Hide resolved
commons/room-types.ts Outdated Show resolved Hide resolved
expo/components/RoomHistoryInfoCard.tsx Outdated Show resolved Hide resolved
expo/app/(tabs)/rooms/[id]/history.tsx Outdated Show resolved Hide resolved
TheRealSharKzy and others added 15 commits April 2, 2024 21:27
@TheRealSharKzy @MAXOUXAX
refactor(frontend) : removing the getApiUrl since I'm now doing the s…
f8b2233 
…upabase request on the frontend
@TheRealSharKzy @MAXOUXAX
chore: changes after review
3909c9f
@TheRealSharKzy @MAXOUXAX
fix(frontend) : now using useSupabaseUser to retrieve current user, s…
bf08ebf 
…ince useUserProfile is giving me an error
@TheRealSharKzy @MAXOUXAX
refactor : change some rooms name
ed48aa7
@TheRealSharKzy @MAXOUXAX
refactor(frontend) : removing an useless page
eb31209
@TheRealSharKzy @MAXOUXAX
refactor(backend) : removing useless method on roomGET
d067f28
@TheRealSharKzy @MAXOUXAX
refactor: Some changes after review
024ad71
@MAXOUXAX
fix: mistyped overflowX property
a472ddd
@MAXOUXAX
refactor: improved getApiUrl
5977ff0
@MAXOUXAX
chore: export necessary consts
226782c
@MAXOUXAX
chore(types): updated database types
0c9fb25
@MAXOUXAX
feat(backend): improved types, getting actual song metadata (WIP)
3419d0f
@MAXOUXAX
refactor: various fixes in frontend and backend
29b6d0f
@MAXOUXAX
fix: song position following array index which is 0-based
109cc66
@MAXOUXAX
feat: played songs correctly showing up
966f0ff
@MAXOUXAX MAXOUXAX force-pushed the feat/room-history-view branch from 96ecdfe to 966f0ff Compare April 2, 2024 19:33
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 2, 2024
View reviewed changes
backend/src/musicplatform/TrackMetadata.ts Fixed Show fixed Hide fixed
expo/components/RoomHistory.tsx Fixed Show fixed Hide fixed
expo/components/UserRoomHistory.tsx
import { useEffect, useState } from "react";
import { FlatList, StyleSheet } from "react-native";

import { supabase } from "../lib/supabase";

Check warning

Code scanning / ESLint

Enforce a convention in module import order. Warning

../lib/supabase import should occur after import of ./Themed
expo/components/UserRoomHistory.tsx
import { FlatList, StyleSheet } from "react-native";

import { supabase } from "../lib/supabase";
import { useUserProfile } from "../lib/userProfile";

Check warning

Code scanning / ESLint

Enforce a convention in module import order. Warning

../lib/userProfile import should occur after import of ./Themed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 3, 2024
View reviewed changes
expo/components/InfoCard.tsx
@@ -0,0 +1,77 @@
import { MaterialIcons } from "@expo/vector-icons";

Check warning

Code scanning / ESLint

Disallow unused variables Warning

'MaterialIcons' is defined but never used.
@MAXOUXAX MAXOUXAX marked this pull request as ready for review April 3, 2024 14:18
@GaspardBBY GaspardBBY merged commit 9abc057 into main Apr 3, 2024
3 checks passed
@GaspardBBY GaspardBBY deleted the feat/room-history-view branch April 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaspardBBY GaspardBBY GaspardBBY approved these changes

@TheRealSharKzy TheRealSharKzy Awaiting requested review from TheRealSharKzy TheRealSharKzy was automatically assigned from datsmysong/developpeurs

@ngomesodent ngomesodent Awaiting requested review from ngomesodent ngomesodent was automatically assigned from datsmysong/developpeurs

Assignees

@MAXOUXAX MAXOUXAX

@TheRealSharKzy TheRealSharKzy

Labels
backend Backend related issues feature Issues that plan on adding features frontend Frontend related issues
Projects
None yet
Milestone
Itération 6
Development

Successfully merging this pull request may close these issues.

Consulter l’historique et les détails d’une salle d’écoute passée
3 participants
@MAXOUXAX @GaspardBBY @TheRealSharKzy