Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phrase patching and utcnow deprecation warning #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sammygrey
Copy link

I've found that partial phrases tend to be overwritten using transcription[-1] = text in the else statement. transcription[-1] = transcription[-1] + text will combine the previous partial phrase with the current partial phrase creating a complete phrase. There is some fallibility with the punctiation and capitlization produced via this method as they are treated as two seperate phrases, but I decided on this for personal use as it is more efficient. If that does bother you though, you can store and combine audio buffers or np arrays and pass that through the model again to construct a complete phrase with no errors of this sort. For my purposes this was a bit overkill so I decided against it. utcnow is also deprecated in favor of just datetime.now or datetime.now(timezone) so I fixed that aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant