Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalaCompatVersion check, closes #732 #740

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

jozic
Copy link
Contributor

@jozic jozic commented Dec 2, 2023

@slandelle per discussion in #732, here's a PR with a test

@jozic jozic marked this pull request as ready for review December 2, 2023 21:37
Copy link
Owner

@davidB davidB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the targeted fix and the test.

We still miss a test when the warning should be raised, and to think if it's relevant to keep this "feature" or to remove it.

@jozic
Copy link
Contributor Author

jozic commented Dec 3, 2023

Hey @davidB, thanks for checking it out!
in fact such a test exists in https://github.com/davidB/scala-maven-plugin/tree/master/src/it/mismatchedScalaVersions
i just coped it and modified to make sure we don't have the warning when compat version is set and scala versions are compatible

or do you talk about some other test?

@jozic
Copy link
Contributor Author

jozic commented Dec 10, 2023

@slandelle do you mind checking this quickly? it's pretty small )

@LeRiton
Copy link

LeRiton commented Feb 8, 2024

Hi everyone,
Thanks @jozic for the patch!
Any plan to merge this for the next release?

@davidB davidB merged commit f4910bc into davidB:master Feb 25, 2024
1 check passed
@jozic jozic deleted the fix-compat-version-check branch February 25, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants