Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches all subdirectories in the bin folder when compiling list of assemblies #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akousmata
Copy link

This partially addresses closed issue #21; there are likely better ways of handling this, but this would be a quick fix.

@xJom
Copy link

xJom commented Nov 7, 2019

Does this help when packages are installed parallell to the bin-folder? Or does it only search subfolders to the bin-folder?

@davidebbo
Copy link
Owner

I haven't built WebActivator in quite some years. If people feel this is important, we can get this change in, but I need to set things up to build this package again.

@akousmata
Copy link
Author

To put this in context, I originally forked the code and made the change for a project at a firm I worked at 6 years ago where this was needed. It worked fine for our needs and so I PR'd. I don't use this library all that much anymore but for those that do, it might be helpful. Although, I would recommend upgrading to a more modern toolchain at this point.

@davidebbo
Copy link
Owner

davidebbo commented Jun 19, 2023

Thanks @akousmata for the extra context. I will leave this alone unless other active users are asking for this.

Also, part of the challenge is that it targets Framework 4.0, which is no longer supported. When opening it in VS 2022, it wants to update it to 4.8, and I'm not sure what breaking effects that could have. The targeting pack for 4.0 is no longer available.

From https://learn.microsoft.com/en-us/dotnet/framework/install/guide-for-developers:
Starting with Visual Studio 2022, Visual Studio no longer includes .NET Framework components for .NET Framework 4.0 - 4.5.1 because these versions are no longer supported. Visual Studio 2022 and later versions can't build apps that target .NET Framework 4.0 through .NET Framework 4.5.1. To continue building these apps, you can use Visual Studio 2019 or an earlier version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants