[RFC] Implement listening on activation environment changes #388
+233
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a protocol that lets a connection to the control socket listen on changes in the global environment issued by
dinitctl setenv
. This opens up a range of possibilities - such as special services that trigger other services when an environment variable appears.It also implements a
dinit-monitor
environment watching mode as a proof of functionality, though likely not acceptable as is (likely at least thestring_view
will need getting rid of?)I intentionally did not implement things like protocol checking and whatnot yet since I want your feedback first.
I should probably also change the protocol a bit - at very least, the envevent should contain information about whether the envvar is newly created or if it overwrites a previous one.
Let me know what you think :)