Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enabled firefox "support" again #1881

Merged
merged 27 commits into from
Jan 31, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Nov 21, 2023

Proposed changes

We could remove our warning for Firefox browser support now. And include the tests as well.

to get merged on 19th of December, the next Firefox release date: https://whattrainisitnow.com/release/?version=121

Resolves #1009

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 📕documentation Improvements or additions to documentation label Nov 21, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Nov 21, 2023
@mfranzke mfranzke self-assigned this Nov 21, 2023
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-docs-firefox-browser-support

@mfranzke mfranzke changed the title refactor(docs): removed firefox browser support warning refactor(docs): reenabled firefox "support" again Dec 5, 2023
@mfranzke mfranzke changed the title refactor(docs): reenabled firefox "support" again refactor: enabled firefox "support" again Dec 5, 2023
@nmerget
Copy link
Member

nmerget commented Jan 2, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

@mfranzke
Copy link
Member Author

mfranzke commented Jan 2, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

… or switch to Firefox Beta temporarily for the moment just to keep this rolling until the next playwright update.

@mfranzke
Copy link
Member Author

mfranzke commented Jan 6, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

@nmerget Firefox 121 has been introduced to playwright so we could use it with the next release of playwright. I know, that you still identified problems with Node 20 with playwright now uses.

@nmerget
Copy link
Member

nmerget commented Jan 8, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

@nmerget Firefox 121 has been introduced to playwright so we could use it with the next release of playwright. I know, that you still identified problems with Node 20 with playwright now uses.

I think we need to solve #1826 as well, before we can migrate

@mfranzke
Copy link
Member Author

mfranzke commented Jan 8, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

@nmerget Firefox 121 has been introduced to playwright so we could use it with the next release of playwright. I know, that you still identified problems with Node 20 with playwright now uses.

I think we need to solve #1826 as well, before we can migrate

that's my fear as well.

@nmerget
Copy link
Member

nmerget commented Jan 10, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

@nmerget Firefox 121 has been introduced to playwright so we could use it with the next release of playwright. I know, that you still identified problems with Node 20 with playwright now uses.

We need to wait for the release

@mfranzke
Copy link
Member Author

mfranzke commented Jan 10, 2024

Playwright has still 120 as firefox version, we need to wait until they updated the browser as well

@nmerget Firefox 121 has been introduced to playwright so we could use it with the next release of playwright. I know, that you still identified problems with Node 20 with playwright now uses.

We need to wait for the release

There's not even a beta version for that new release so far 😢:
https://www.npmjs.com/package/@playwright/test?activeTab=versions

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Jan 17, 2024
@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Jan 23, 2024
@github-actions github-actions bot removed the 🚢📀cicd Changes inside .github folder label Jan 31, 2024
@nmerget nmerget marked this pull request as ready for review January 31, 2024 12:29
@nmerget nmerget merged commit b49853a into main Jan 31, 2024
26 checks passed
@nmerget nmerget deleted the refactor-docs-firefox-browser-support branch January 31, 2024 12:30
@mfranzke mfranzke restored the refactor-docs-firefox-browser-support branch January 31, 2024 13:14
@mfranzke mfranzke deleted the refactor-docs-firefox-browser-support branch January 31, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Firefox (support) again
2 participants