Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(accordion): adapt native standard for behaviour #3218

Merged
merged 30 commits into from
Nov 19, 2024
Merged

refactor(accordion): adapt native standard for behaviour #3218

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ea1dc79
refactor: first try
mfranzke Sep 22, 2024
626defa
refactor: another try
mfranzke Sep 22, 2024
2c32f13
chore: update implementation for accordion
nmerget Sep 24, 2024
0e6f635
chore: update sr snapshots
nmerget Sep 24, 2024
f36eb20
fix: issue with initOpenIndex
nmerget Sep 25, 2024
07882a6
fix: issue with typescript
nmerget Sep 25, 2024
6ec5788
Merge branch 'main' into 1630-accordion-adapt-native-standard
mfranzke Sep 25, 2024
3733abf
fix: issue from PR
nmerget Oct 31, 2024
194fee4
chore: update from main
nmerget Oct 31, 2024
61e0842
fix: issue from stencil typescript
nmerget Oct 31, 2024
0825356
fix: issue with accordion item
nmerget Oct 31, 2024
b0839d1
fix: issue with component test for accordion item
nmerget Oct 31, 2024
1861da7
fix: issue with component test for vue
nmerget Oct 31, 2024
681d428
Update accordion-a11y.spec.ts
mfranzke Nov 19, 2024
90bfe09
chore: update from main
nmerget Nov 19, 2024
58ab085
Merge remote-tracking branch 'origin/1630-accordion-adapt-native-stan…
nmerget Nov 19, 2024
fe8cfc1
Merge branch 'main' into 1630-accordion-adapt-native-standard
mfranzke Nov 19, 2024
9e4e319
Update accordion-a11y.spec.ts
mfranzke Nov 19, 2024
3a5058f
Update accordion-item-a11y.spec.ts
mfranzke Nov 19, 2024
f9d2ab6
fix: issue with linting
nmerget Nov 19, 2024
2d3c79f
Merge remote-tracking branch 'origin/1630-accordion-adapt-native-stan…
nmerget Nov 19, 2024
5aa4277
Update accordion.scss
mfranzke Nov 19, 2024
1c07a91
Merge remote-tracking branch 'origin/1630-accordion-adapt-native-stan…
nmerget Nov 19, 2024
bf37c15
Update accordion-item.scss
mfranzke Nov 19, 2024
87c1e7b
Update accordion-item.spec.tsx
mfranzke Nov 19, 2024
d70f0f1
Update packages/components/src/components/accordion/accordion.lite.tsx
nmerget Nov 19, 2024
98d050e
chore: update snapshots
nmerget Nov 19, 2024
6439579
Merge branch 'main' into 1630-accordion-adapt-native-standard
mfranzke Nov 19, 2024
6144f25
chore: update snapshots
nmerget Nov 19, 2024
c7f5019
Merge remote-tracking branch 'origin/1630-accordion-adapt-native-stan…
nmerget Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/components/accordion/accordion.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default function DBAccordion(props: DBAccordionProps) {

onUpdate(() => {
if (ref && state._initOpenIndexDone) {
if (props.initOpenIndex?.length > 0) {
if (props?.initOpenIndex && props.initOpenIndex?.length > 0) {
nmerget marked this conversation as resolved.
Show resolved Hide resolved
const childDetails = ref.getElementsByTagName('details');
if (childDetails) {
const initOpenIndex =
Expand Down
Loading