Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removed inner div inside section.lite.tsx #3477

Merged
merged 8 commits into from
Nov 19, 2024
Merged

refactor: removed inner div inside section.lite.tsx #3477

merged 8 commits into from
Nov 19, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 18, 2024

Proposed changes

Removed inner <div> from DBSection to handle proper layouting.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) November 18, 2024 15:29
@nmerget nmerget added the 👩‍👧‍👦community feedback Feedback from community label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-section-inner-div

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Nov 18, 2024
@nmerget nmerget added this to the v0.6.0 milestone Nov 18, 2024
@mfranzke mfranzke changed the title refactor: removed inner div inside section.lite.tsx refactor: removed inner div inside section.lite.tsx Nov 18, 2024
mfranzke
mfranzke previously approved these changes Nov 18, 2024
View reviewed changes
@nmerget nmerget requested a review from mfranzke November 19, 2024 10:57
@nmerget
Merge remote-tracking branch 'origin/main' into refactor-section-inne…
3768977 
…r-div

# Conflicts:
#	showcases/showcase-styles.css
@nmerget nmerget merged commit 5d3cb0f into main Nov 19, 2024
72 checks passed
@nmerget nmerget deleted the refactor-section-inner-div branch November 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
👩‍👧‍👦community feedback Feedback from community 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke