Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect import #3579

Closed
wants to merge 2 commits into from
Closed

fix: incorrect import #3579

wants to merge 2 commits into from

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 9, 2024 •
edited
Loading

Proposed changes

fixed incorrect import as reported within VS Code:

'ReplaceInFileConfig' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.ts(1484)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🐛bug Something isn't working label Dec 9, 2024
@mfranzke mfranzke self-assigned this Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-incorrect-import

@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Dec 9, 2024
@mfranzke mfranzke marked this pull request as ready for review December 10, 2024 07:44
@mfranzke
Copy link
Member Author

this has been integrated into #3582

@mfranzke mfranzke closed this Dec 10, 2024
@nmerget nmerget deleted the fix-incorrect-import branch December 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
🐛bug Something isn't working 🏗foundations Changes inside foundations folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke