Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: not disable ally test rule anymore #3640

Merged
merged 7 commits into from
Jan 6, 2025
Merged

refactor: not disable ally test rule anymore #3640

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dcde955
refactor: not disable color-contrast rule anymore
mfranzke Jan 3, 2025
6d05ae8
refactor: not disable aria_attribute_valid rule anymore
mfranzke Jan 3, 2025
923f38d
Revert "refactor: not disable aria_attribute_valid rule anymore"
mfranzke Jan 3, 2025
24e2454
Merge branch 'main' into 3332-refactor-not-disable-aria_attribute_val…
mfranzke Jan 3, 2025
1908b0d
Update link-a11y.spec.ts
mfranzke Jan 6, 2025
a7b2d9f
refactor: prettier
mfranzke Jan 6, 2025
72d1e7b
Merge branch 'main' into 3332-refactor-not-disable-aria_attribute_val…
mfranzke Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/components/src/components/select/select.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const testA11y = () => {
const accessibilityScanResults = await new AxeBuilder({ page })
.include('.db-select')
.exclude('test-placeholder')
.disableRules('color-contrast')
.analyze();

expect(accessibilityScanResults.violations).toEqual([]);
Expand Down
9 changes: 2 additions & 7 deletions showcases/e2e/link/link-a11y.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,12 @@ import { test } from '@playwright/test';
import { isStencil, runA11yCheckerTest, runAxeCoreTest } from '../default.ts';
import { lvl3 } from '../fixtures/variants';

const axeDisableRules = isStencil(process.env.showcase)
? ['color-contrast']
: [];

const aCheckerDisableRules = isStencil(process.env.showcase)
? ['text_contrast_sufficient', 'aria_attribute_valid']
: ['aria_attribute_valid']; // TODO: This is a false positive -> add an issue in https://github.com/IBMa/equal-access

test.describe('DBLink', () => {
runAxeCoreTest({ path: '02/link', axeDisableRules });
mfranzke marked this conversation as resolved.
Show resolved Hide resolved
runAxeCoreTest({ path: '02/link', color: lvl3, axeDisableRules });
runAxeCoreTest({ path: '02/link', density: 'functional', axeDisableRules });
runAxeCoreTest({ path: '02/link', color: lvl3 });
runAxeCoreTest({ path: '02/link', density: 'functional' });
runA11yCheckerTest({ path: '02/link', aCheckerDisableRules });
});
Loading