fix bad f-string placement on describe_one_table_details
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bennet
approved these changes
Apr 25, 2024
|
Thank you @saucoide . Feel free to add your contribution to changelog. |
The string is split in 2 and and concatenated implicitly, but the f-string is applied only to the first one, which has no variables to replace, while the second one does and inserts a literal `{oid}`
this is breaking `\d` on patterns with a pg syntax error e.g:
`\d mytabl*`
|
@j-bennet done - added it as "upcoming" since there is no unreleased version to add it to, hope that works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The string is split in 2 and and concatenated implicitly, but the f-string is applied only to the first one, which has no variables to replace, while the second one does and inserts a literal
{oid}this is breaking
\don patterns with a pg syntax error e.g:\d mytabl*Checklist
changelog.rst.pip install pre-commit && pre-commit install), and ranblackon my code.