Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures #113

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Test failures #113

wants to merge 8 commits into from

Conversation

dblock
Copy link
Owner

@dblock dblock commented Nov 17, 2022

Testing failures.

dblock and others added 7 commits November 15, 2022 17:20
…d replica (opensearch-project#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <[email protected]>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <[email protected]>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

Signed-off-by: Ashish Singh <[email protected]>
With the test-retry plugin we can get a successful result when tests
fail but the succeed on a retry. This change ensures that the PR comment
lists the flaky failures even when the overall run is a success.

Signed-off-by: Andrew Ross <[email protected]>
…ensearch-project#5277)

Calls to `Collection.toArray()` is not consistent and in many places and use a pre-sized array parameter. This change makes a consistent use of the `toArray(new T[0])`. The empty array usage is considered faster, safer and cleaner than the sized based array approach.

Signed-off-by: Rabi Panda <[email protected]>
…ect#5278)

The `sendBodyAsSourceParam` method determines whether it should send the body as query parameter. It used to check the content length of the entity which in some cases (e.g. regex expression) is much shorter than the encoded-url and may result in a TooLongHttpLineException.

This commit makes an additional check on the length of the url-encoded string. To avoid unnecessary computation it is only checked when the RandomizedTest.rarely() returns true.

Signed-off-by: Rabi Panda <[email protected]>
…tests (opensearch-project#5262)

* Make viaNode more deterministic fixing flaky AwarenessAttributeDecommissionIT tests 

Signed-off-by: Rishab Nahata <[email protected]>
@dblock dblock force-pushed the test-failures branch 16 times, most recently from aab4475 to 4f9bed7 Compare November 17, 2022 15:17
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
Repository owner deleted a comment from github-actions bot Nov 17, 2022
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: FAILURE ❌
  • FAILURES:
      6 org.opensearch.script.expression.MoreExpressionIT.classMethod
      4 org.opensearch.search.aggregations.DelayedShardAggregationClientYamlTestSuiteIT.test {yaml=delayed_aggs/10_basic/Delayed Aggs}
      4 org.opensearch.index.mapper.murmur3.MapperMurmur3ClientYamlTestSuiteIT.test {yaml=mapper_murmur3/10_basic/Mapper Murmur3}
      4 org.opensearch.example.expertscript.ExpertScriptClientYamlTestSuiteIT.test {yaml=script_expert_scoring/20_score/document scoring}
      4 org.opensearch.example.customsuggester.CustomSuggesterClientYamlTestSuiteIT.test {yaml=custom-suggester/20_suggest/test custom suggester}
      1 org.opensearch.test.rest.WaitForRefreshAndCloseIT.testUpdateAndThenClose
      1 org.opensearch.test.rest.WaitForRefreshAndCloseIT.testIndexAndThenClose
      1 org.opensearch.test.rest.WaitForRefreshAndCloseIT.testDeleteAndThenClose
      1 org.opensearch.test.rest.RequestsWithoutContentIT.testSimulatePipelineMissingBody
      1 org.opensearch.test.rest.RequestsWithoutContentIT.testPutSettingsMissingBody

Repository owner deleted a comment from github-actions bot Nov 17, 2022
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌

  • FAILURES:

  • URL:

  • CommitID: 671bef0
    Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants