-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor / additional flag autoGenerateIamPermissions #1089
base: main
Are you sure you want to change the base?
Conversation
- remove CreationType (Single, Multi) - replace with ResourceType (PARAMETER_MULTI) and move it to properties fixes: #1076 - add property 'autoGenerateIamPermissions' fixes: #1087 - add property 'role' for SopsSyncProvider fixes: #1087 - move resourceType from syncOptions to syncProperties, as it shouldn't be set by users - move permissionhandling to own functions, to reduce cyclomatic compexity
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
- Coverage 72.30% 71.80% -0.51%
==========================================
Files 3 3
Lines 455 461 +6
==========================================
+ Hits 329 331 +2
- Misses 88 91 +3
- Partials 38 39 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
I've build this branch local and deployed it without problems in our MultiParameter setup. 👍 |
Signed-off-by: github-actions <[email protected]>
Fixes #1076, #1087