-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot time data type #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleArk
reviewed
Jun 26, 2024
MichelleArk
reviewed
Jun 26, 2024
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Outdated
Show resolved
Hide resolved
peterallenwebb
previously approved these changes
Aug 26, 2024
mikealfare
reviewed
Aug 26, 2024
dbt/include/global_project/macros/materializations/snapshots/snapshot.sql
Outdated
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/snapshot.sql
Outdated
Show resolved
Hide resolved
MichelleArk
reviewed
Sep 3, 2024
gshank
force-pushed
the
snapshot_time_data_type
branch
from
September 3, 2024 22:23
ad7b550
to
e303ddd
Compare
MichelleArk
previously approved these changes
Sep 3, 2024
mikealfare
approved these changes
Sep 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #242
Problem
The values of the timestamp columns in a snapshot are different than the source table, leading to unexpected results.
Solution
Add comparison of 'snapshot_get_time' and snapshot config 'updated_at' columns and issue a warning.
Note: test case is in dbt-labs/dbt-core#10352
Checklist