Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot time data type #243

Merged
merged 19 commits into from
Sep 4, 2024
Merged

Snapshot time data type #243

merged 19 commits into from
Sep 4, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jun 21, 2024

resolves #242

Problem

The values of the timestamp columns in a snapshot are different than the source table, leading to unexpected results.

Solution

Add comparison of 'snapshot_get_time' and snapshot config 'updated_at' columns and issue a warning.

Note: test case is in dbt-labs/dbt-core#10352

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner June 21, 2024 18:33
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
@gshank gshank requested a review from MichelleArk August 21, 2024 20:27
peterallenwebb
peterallenwebb previously approved these changes Aug 26, 2024
@gshank gshank force-pushed the snapshot_time_data_type branch from ad7b550 to e303ddd Compare September 3, 2024 22:23
MichelleArk
MichelleArk previously approved these changes Sep 3, 2024
@gshank gshank requested a review from MichelleArk September 4, 2024 16:32
@gshank gshank merged commit c310bc5 into main Sep 4, 2024
15 checks passed
@gshank gshank deleted the snapshot_time_data_type branch September 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if snapshot_get_time is different data type than snapshot 'updated_at' field
4 participants