Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize actions for reuse across adapters #54

Merged
merged 21 commits into from
Jan 29, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

Problem

We would like to reuse the same actions across all adapters for the release process.

Solution

  • Pull repo-specific items out of the action and put into the workflow
  • Parameterize the actions with sensible defaults
  • Add ability to publish to PyPI test
  • Add ability to publish dbt-tests-adapter or dbt-adapters`

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jan 26, 2024
@mikealfare
Copy link
Contributor Author

This workflow successfully published dbt-adapters and dbt-tests-adapter to tests.pypi.org:

https://test.pypi.org/project/dbt-adapters/0.1.0a6/
https://test.pypi.org/project/dbt-tests-adapter/1.8.0a2/

@mikealfare
Copy link
Contributor Author

The actions are being reused successfully by dbt-postgres:

dbt-labs/dbt-postgres#1

The integration tests are failing there because of setting up postgres. This is a separate issue.

@mikealfare mikealfare merged commit f896eff into main Jan 29, 2024
6 of 7 checks passed
@mikealfare mikealfare deleted the config/release branch January 29, 2024 21:23
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Jan 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants