-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement support bucket function for more than 100 partitions #549
Merged
svdimchenko
merged 16 commits into
dbt-labs:main
from
sanromeo:feat/implementation-athena-partition-limit-for-bucketing
Jan 4, 2024
Merged
feat: Implement support bucket function for more than 100 partitions #549
svdimchenko
merged 16 commits into
dbt-labs:main
from
sanromeo:feat/implementation-athena-partition-limit-for-bucketing
Jan 4, 2024
+293
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanromeo
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
December 28, 2023 11:51
sanromeo
changed the title
Implement support bucket function for more than 100 partitions
feat: Implement support bucket function for more than 100 partitions
Dec 28, 2023
Now I will also write and add the unit and functional tests 👌 |
svdimchenko
reviewed
Dec 28, 2023
svdimchenko
reviewed
Dec 28, 2023
svdimchenko
reviewed
Dec 28, 2023
svdimchenko
reviewed
Dec 28, 2023
nicor88
reviewed
Jan 2, 2024
nicor88
reviewed
Jan 2, 2024
nicor88
reviewed
Jan 2, 2024
dbt/include/athena/macros/materializations/models/helpers/get_partition_batches.sql
Outdated
Show resolved
Hide resolved
…ion-limit-for-bucketing
…ate and datetime column, Separate logic for bucket and non-bucket columns in different macros
…ion-limit-for-bucketing
svdimchenko
approved these changes
Jan 4, 2024
nicor88
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svdimchenko good looks good and functional tests are enough for me.
Thanks for the implementation @sanromeo 💯
encountered this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #529
FUNCTION_NOT_FOUND: line 2:21: Function 'bucket' not registered
by adding regex for extract bucket column frompartitioned_by
configmurmur3_hash
method to calculate bucket number of bucket column value as it works for Iceberg tables in Athenapartitioned_by
config for Iceberg tablesget_partition_batches
macros with put bucket_column values to appropriate bucket number and than and add values to final WHERE condition for batchesTested on next column types for
bucket
function:Not works now for next types (needed additional implementation in dbt-athena-community adapter):
Model used to test
A part of log output:
Info to compare how WHERE clause above generated for this values:
Checklist