feat: Implement drop_glue_database macro and method #766
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicor88
reviewed
Dec 16, 2024
nicor88
reviewed
Dec 16, 2024
|
@svdimchenko looks good. I left a minor nit about the logger. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
svdimchenko
changed the title
nicor88
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Looks good @svdimchenko
@colin-rogers-dbt @mikealfare could you have a look here, and eventually merge it?
colin-rogers-dbt
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Athena query fails
drop database <db> cascade;when it contains iceberg tables.Closes #768
Checklist