Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular import #11137

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix circular import #11137

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1231807
fix circular import
dradetsky Dec 11, 2024
5789e47
changelog
dradetsky Dec 11, 2024
f89980b
Add GitHub issue number
dbeatty10 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20241211-132203.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix circular dependency
time: 2024-12-11T13:22:03.637443979-08:00
custom:
Author: dradetsky
Issue: none
dbeatty10 marked this conversation as resolved.
Show resolved Hide resolved
1 change: 0 additions & 1 deletion core/dbt/cli/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from .main import cli as dbt_cli # noqa
10 changes: 1 addition & 9 deletions core/dbt/config/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import Any, Dict, Optional, Tuple

from dbt.adapters.contracts.connection import Credentials, HasCredentials
from dbt.cli.resolvers import default_profiles_dir
from dbt.clients.yaml_helper import load_yaml_text
from dbt.contracts.project import ProfileConfig
from dbt.events.types import MissingProfileTarget
Expand Down Expand Up @@ -164,15 +165,6 @@ def pick_profile_name(
args_profile_name: Optional[str],
project_profile_name: Optional[str] = None,
) -> str:
# TODO: Duplicating this method as direct copy of the implementation in dbt.cli.resolvers
# dbt.cli.resolvers implementation can't be used because it causes a circular dependency.
# This should be removed and use a safe default access on the Flags module when
# https://github.com/dbt-labs/dbt-core/issues/6259 is closed.
def default_profiles_dir():
from pathlib import Path

return Path.cwd() if (Path.cwd() / "profiles.yml").exists() else Path.home() / ".dbt"

profile_name = project_profile_name
if args_profile_name is not None:
profile_name = args_profile_name
Expand Down
Loading