-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case for merge_exclude_columns
#8268
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8268 +/- ##
==========================================
+ Coverage 88.97% 89.00% +0.03%
==========================================
Files 181 181
Lines 22956 22956
==========================================
+ Hits 20424 20431 +7
+ Misses 2532 2525 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
resolves #8267
Problem
The source code here doesn't include TestMergeExcludeColumns like dbt-snowflake does here or dbt-redshift does here.
This is because merge wasn't a supported incremental strategy for dbt-postgres until 1.6 and adding relevant functional tests was overlooked during implementation in #6951.
The other related test cases have a class that pytest will pick up:
dbt-core/tests/functional/adapter/incremental/test_incremental_unique_id.py
Line 566 in db69473
dbt-core/tests/functional/adapter/incremental/test_incremental_predicates.py
Line 144 in db69473
dbt-core/tests/functional/adapter/incremental/test_incremental_on_schema_change.py
Line 99 in db69473
Solution
Implement a test case that pytest will pick up (namely a class that begins with "Test").
Prerequisites
In order for this PR to work, it needs this:
Checklist