Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog entry check for pull requests #108

Merged
merged 7 commits into from
May 23, 2024

Conversation

mikealfare
Copy link
Contributor

resolves #57

Problem

We don't have a check for changelog entries on pull requests, which could lead to changes not being captured in the release changelog.

Solution

Add the check that we have in other adapter repos.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this May 23, 2024
@mikealfare mikealfare requested a review from a team as a code owner May 23, 2024 21:30
@cla-bot cla-bot bot added the cla:yes label May 23, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot May 23, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot May 23, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide.

@mikealfare mikealfare merged commit 96dd860 into main May 23, 2024
19 of 20 checks passed
@mikealfare mikealfare deleted the require-changelog-entry branch May 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Require changie entries
2 participants