Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #125

Closed
wants to merge 12 commits into from

Conversation

McKnight-42
Copy link
Contributor

associated with: dbt-labs/dbt-adapters#250
docs dbt-labs/docs.getdbt.com/#

Problem

user raised issue around "While working with DBT incremental config: on_schema_change='append_new_columns'
The append new columns flag is not able to capture the correct case-sensitive column name and add it to the incremental table causing the run to fail."

they stated they were using snowflake.

Solution

add a new test to dbt-adapters-tests to check that column quoting case sensitivity is expressed correctly, update all macros in adapters as needed if they do not use the default implementation and test default implementing macros to see if we need to update the dbt-adapters macro as well.

Todo:

  • test with rest of adapters (see if dbt-adapter default version of macro needs to be changed or any other adapter override version of macro).
  • make sure new tests works in all adapters as needed
  • update requirements files either dev-requirements or project.toml files before merger

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Jul 11, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 11, 2024
@McKnight-42 McKnight-42 changed the title Mcknight/2819 [CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation Aug 5, 2024
@McKnight-42 McKnight-42 marked this pull request as ready for review August 5, 2024 21:38
@McKnight-42 McKnight-42 requested a review from a team as a code owner August 5, 2024 21:38
@McKnight-42 McKnight-42 removed their assignment Aug 9, 2024
@mikealfare mikealfare closed this Nov 9, 2024
@mikealfare mikealfare deleted the mcknight/2819 branch November 9, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants