Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook tests #153

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Fix hook tests #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e8cf3a
Fix hook tests
aranke Oct 1, 2024
6a2820d
Remove extra whitespace
aranke Oct 1, 2024
bd2f488
Use dbt-adapters off the fix_hook_tests branch
aranke Oct 1, 2024
a376228
Update pyproject.toml
aranke Oct 1, 2024
1a5d1de
Discard changes to pyproject.toml
aranke Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .changes/1.9.0-b1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,3 @@
- [@morsapaes](https://github.com/morsapaes) ([#120](https://github.com/dbt-labs/dbt-postgres/issues/120))
- [@peterallenwebb](https://github.com/peterallenwebb) ([#123](https://github.com/dbt-labs/dbt-postgres/issues/123))
- [@versusfacit](https://github.com/versusfacit) ([#85](https://github.com/dbt-labs/dbt-postgres/issues/85))

8 changes: 4 additions & 4 deletions tests/functional/schema_tests/test_schema_v2_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@ def test_hooks_do_run_for_tests(
):
# This passes now that hooks run, a behavior we changed in v1.0
results = run_dbt(["test", "--model", "ephemeral"])
assert len(results) == 1
assert len(results) == 3
for result in results:
assert result.status == "pass"
assert result.status in ("pass", "success")
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)

Expand Down Expand Up @@ -505,9 +505,9 @@ def test_these_hooks_dont_run_for_tests(
):
# This would fail if the hooks ran
results = run_dbt(["test", "--model", "ephemeral"])
assert len(results) == 1
assert len(results) == 3
for result in results:
assert result.status == "pass"
assert result.status in ("pass", "success")
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)

Expand Down