test name typo fix #1005
Merged
test name typo fix #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McKnight-42
added
backport 1.6.latest
backport 1.7.latest
mikealfare
reviewed
Apr 10, 2024
| @@ -15,7 +15,7 @@ | |||
|
|
|||
|
|
|||
| @pytest.mark.skip_profile("apache_spark", "spark_session") | |||
| class TestSparkBigqueryClonePossible(BaseClonePossible): | |||
There was a problem hiding this comment.
Classic. Let's make sure that dbt-databricks is not inheriting this test case.
There was a problem hiding this comment.
looks like they inherit staright from dbt-adapters https://github.com/databricks/dbt-databricks/blob/main/tests/functional/adapter/dbt_clone/test_dbt_clone.py
There was a problem hiding this comment.
and they have only had this test since their 1.7 looks like
colin-rogers-dbt
approved these changes
Apr 11, 2024
McKnight-42
added
backport 1.6.latest
backport 1.7.latest
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit 0646c24)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
(cherry picked from commit 0646c24)
McKnight-42
added a commit
that referenced
this pull request
Apr 12, 2024
(cherry picked from commit 0646c24) Co-authored-by: Matthew McKnight <[email protected]>
McKnight-42
added a commit
that referenced
this pull request
Apr 12, 2024
(cherry picked from commit 0646c24) Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
when checking to see which all adapters have clone capabilities noticed a test misname
Solution
Checklist