Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-database date macro #1030

Merged
merged 6 commits into from
May 13, 2024
Merged

Cross-database date macro #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f535440
Cross-database `date` macro
dbeatty10 May 1, 2024
529461f
Temporary dev requirements for testing
dbeatty10 May 1, 2024
06563d2
Update changelog entry
dbeatty10 May 2, 2024
aa8fe68
Revert "Temporary dev requirements for testing"
dbeatty10 May 2, 2024
58c3d24
Merge branch 'main' into dbeatty/date-macro
dbeatty10 May 7, 2024
a4bf2ac
Merge branch 'main' into dbeatty/date-macro
dbeatty10 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20240501-151904.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Cross-database `date` macro
time: 2024-05-01T15:19:04.822157-06:00
custom:
Author: dbeatty10
Issue: 1031
5 changes: 5 additions & 0 deletions dbt/include/spark/macros/utils/date.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{% macro spark__date(year, month, day) -%}
{%- set dt = modules.datetime.date(year, month, day) -%}
{%- set iso_8601_formatted_date = dt.strftime('%Y-%m-%d') -%}
to_date('{{ iso_8601_formatted_date }}', 'yyyy-MM-dd')
{%- endmacro %}
5 changes: 5 additions & 0 deletions tests/functional/adapter/utils/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from dbt.tests.adapter.utils.test_cast_bool_to_text import BaseCastBoolToText
from dbt.tests.adapter.utils.test_concat import BaseConcat
from dbt.tests.adapter.utils.test_current_timestamp import BaseCurrentTimestampNaive
from dbt.tests.adapter.utils.test_date import BaseDate
from dbt.tests.adapter.utils.test_dateadd import BaseDateAdd
from dbt.tests.adapter.utils.test_datediff import BaseDateDiff
from dbt.tests.adapter.utils.test_date_trunc import BaseDateTrunc
Expand Down Expand Up @@ -80,6 +81,10 @@ class TestCurrentTimestamp(BaseCurrentTimestampNaive):
pass


class TestDate(BaseDate):
pass


class TestDateAdd(BaseDateAdd):
pass

Expand Down
Loading