Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the spark version to the current version #1055

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jun 21, 2024

resolves #1054

Problem

Solution

  • update the version in the tests
  • update pydanic<1.10.3 to pydanic>=1.10.8
  • add a docstring explaining all of this
  • exclude the koalas test

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jun 21, 2024
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare mikealfare marked this pull request as ready for review June 25, 2024 01:11
@mikealfare mikealfare requested a review from a team as a code owner June 25, 2024 01:11
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jun 25, 2024
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the comments.

@mikealfare mikealfare merged commit 824ca0f into main Jun 26, 2024
23 of 24 checks passed
@mikealfare mikealfare deleted the fix-spacy-dep-tests branch June 26, 2024 16:06
Copy link
Contributor

The backport to 1.8.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-1055-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 824ca0f2249d145234f21d7e4066e033a273e2e2
# Push it to GitHub
git push --set-upstream origin backport-1055-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest

Then, create a pull request where the base branch is 1.8.latest and the compare/head branch is backport-1055-to-1.8.latest.

mikealfare added a commit that referenced this pull request Oct 24, 2024
* update the spark version to the current version
* update pin for pydantic to resolve explosion/spaCy#12659
* exclude koalas dataframes from test

(cherry picked from commit 824ca0f)
VersusFacit added a commit that referenced this pull request Oct 26, 2024
…#1055) (#1130)

* Update the spark version to the current version (#1055)

* update the spark version to the current version
* update pin for pydantic to resolve explosion/spaCy#12659
* exclude koalas dataframes from test

(cherry picked from commit 824ca0f)

* Backport preleases.

* Fix numpy issue.

---------

Co-authored-by: VersusFacit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tech Debt] Update configuration on Databricks tests
2 participants