Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3.12 in workflow files and configs. #1081

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Jul 28, 2024

resolves #981

Problem

READ BEFORE REVIEWING

Adding Python 3.12 should pass a series of tests
pytest tests/unit local
pytest tests/functional local (we do this with Dagger now)
dbt seed && dbt run in a local jaffle shop using plain pip install dbt-spark with 3.12 active covered by smoke testing run
✅ smoke testing run using test-bundle on snowflake against the jaffle-shop-base scenario with 3.12.3 active

  • we'll need to add brew install unixodbc to Always Sunny for it to work with pyodbc 5.* which is needed for spark 🐢 ♾️

✅ GHA workflow involving integration tests (see below)
✅ release workflow still works (I'm not changing the 3.11 version here

Solution

We needed to update the pyodbc to get this working! It had no wheels for 3.12.

See this thread for one such documentation of this fact

No other changes beyond GHA workflows and setup.py are needed for this adapter.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Jul 28, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 28, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Jul 28, 2024
@VersusFacit VersusFacit force-pushed the ADAP-981/add_python_312_support branch from fb1abd9 to 8dc6b6e Compare July 28, 2024 07:27
@VersusFacit VersusFacit force-pushed the ADAP-981/add_python_312_support branch from 800eba0 to 539cd0c Compare July 28, 2024 07:42
@VersusFacit
Copy link
Contributor Author

VersusFacit commented Jul 28, 2024

release run to show steps working (except for audit obviously)

Temporarily set integration test parameter to 3.12 to show integration tests working.
edit: https://github.com/dbt-labs/dbt-spark/actions/runs/10308525832

@VersusFacit VersusFacit marked this pull request as ready for review August 8, 2024 19:35
@VersusFacit VersusFacit requested a review from a team as a code owner August 8, 2024 19:35
@VersusFacit
Copy link
Contributor Author

VersusFacit commented Aug 8, 2024

image Corroboration of smoke testing jaffle shop coming up clear.

@VersusFacit
Copy link
Contributor Author

VersusFacit commented Aug 8, 2024

Before merge I'm going to revert the test version to 3.11 and open a ticket in smoke testing repo explaining what needs done to ensure we can use it with 3.12 on this adapter.

@VersusFacit
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Aug 8, 2024

The cla-bot has been summoned, and re-checked this pull request!

@VersusFacit VersusFacit merged commit 2124423 into main Aug 8, 2024
21 checks passed
@VersusFacit VersusFacit deleted the ADAP-981/add_python_312_support branch August 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Spike on supporting Py3.12 in dbt-spark
2 participants