Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow untyped def's #767

Merged
merged 13 commits into from
Jun 24, 2023
Merged

Disallow untyped def's #767

merged 13 commits into from
Jun 24, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented May 10, 2023

resolves #760

Description

Checklist

@Fokko Fokko requested a review from a team as a code owner May 10, 2023 14:43
@Fokko Fokko requested a review from McKnight-42 May 10, 2023 14:43
@cla-bot cla-bot bot added the cla:yes label May 10, 2023
@Fokko Fokko force-pushed the fd-enable-mypy branch 2 times, most recently from 0431ce0 to c3031dd Compare May 10, 2023 16:16
@Fokko
Copy link
Contributor Author

Fokko commented May 10, 2023

Looks like there are some issues with Github: https://www.githubstatus.com/ I'll rerun the actions later today.

@Fokko Fokko force-pushed the fd-enable-mypy branch 3 times, most recently from 4ab4dc9 to 2376283 Compare May 10, 2023 22:31
@Fokko Fokko force-pushed the fd-enable-mypy branch 2 times, most recently from 7d25c86 to a92b25f Compare May 14, 2023 19:03
@Fokko
Copy link
Contributor Author

Fokko commented May 14, 2023

@mikealfare would you have a few cycles to dig into this one?

@mikealfare mikealfare requested review from a team, aranke and VersusFacit and removed request for a team May 16, 2023 15:04
@mikealfare mikealfare requested review from a team and removed request for McKnight-42, aranke and VersusFacit May 16, 2023 15:09
@Fokko
Copy link
Contributor Author

Fokko commented May 27, 2023

Thanks @mikealfare

@VersusFacit
Copy link
Contributor

VersusFacit commented Jun 6, 2023 •
edited
Loading

Giving this PR a CI kick to get it green (at least, tis the hope)

@Fokko
Copy link
Contributor Author

Fokko commented Jun 14, 2023

@mikealfare @VersusFacit Any chance we can move this forward? :)

@Fokko
Copy link
Contributor Author

Fokko commented Jun 14, 2023

@jtcohen6 maybe? :)

@mikealfare mikealfare merged commit 8ea1597 into dbt-labs:main Jun 24, 2023
15 checks passed
@Fokko Fokko deleted the fd-enable-mypy branch June 26, 2023 07:34
@Fokko
Copy link
Contributor Author

Fokko commented Jun 26, 2023

Thanks @mikealfare 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Disallow untyped defs
3 participants
@Fokko @VersusFacit @mikealfare