Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the all flag to the pip install #778

Closed

Conversation

JCZuurmond
Copy link
Collaborator

@JCZuurmond JCZuurmond commented May 16, 2023

Description

Make sure you install all dependencies when contributing.

Checklist

@JCZuurmond JCZuurmond requested a review from a team as a code owner May 16, 2023 15:56
@cla-bot cla-bot bot added the cla:yes label May 16, 2023
@mikealfare
Copy link
Contributor

We've been running pip install -r requirements.txt (via tox/make) to do this, but I actually like this better as we don't have to maintain two versions, one in setup.py and one in requirements.txt. Would you mind making the updates to tox.ini and Makefile and removing requirements.txt to see if that all works together?

@JCZuurmond JCZuurmond force-pushed the add-all-to-contributing-guide branch from 5b9b64d to a317690 Compare June 21, 2023 09:01
@JCZuurmond
Copy link
Collaborator Author

@mikealfare : I updated the accordingly. Could you have a look why the unit test CircleCI is failing due to a missing pyproject.toml. The Github action unit test is not failing

@mikealfare
Copy link
Contributor

The tests on CircleCI are failing with this error:

#!/bin/bash -eo pipefail
tox -e flake8,unit
ERROR: missing /home/dbt_test_user/project/pyproject.toml


Exited with code exit status 1
CircleCI received exit code 1

We don't use pyproject.toml yet. I wonder if removing requirements.txt entirely caused some under the hood magic to look for pyproject.toml and then fail if it's not found. Just for fun, do you mind uploading an empty requirements.txt with a comment along the lines of "this makes CircleCI happy"?

Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 22, 2023
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants