Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcknight/fix test store test #832

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jul 12, 2023

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

test_store_test_failures tests leave hanging artifacts due to change in schema name, need to add a teardown method to make sure we drop alt schema to stop build up of unnecessary schemas in ci/cd database overtime.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Jul 12, 2023
@McKnight-42 McKnight-42 requested a review from a team as a code owner July 12, 2023 19:17
@McKnight-42 McKnight-42 self-assigned this Jul 12, 2023
@cla-bot cla-bot bot added the cla:yes label Jul 12, 2023
@McKnight-42 McKnight-42 merged commit 99c5c5a into main Oct 17, 2023
17 checks passed
@McKnight-42 McKnight-42 deleted the mcknight/fix-test-store-test branch October 17, 2023 16:35
@McKnight-42
Copy link
Contributor Author

todo create backports as needed

github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
* add teardown_method for store_test_fail test

* create pr

* add teardown to delta test class as it also builds tests on alt schema

(cherry picked from commit 99c5c5a)
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
* add teardown_method for store_test_fail test

* create pr

* add teardown to delta test class as it also builds tests on alt schema

(cherry picked from commit 99c5c5a)
@McKnight-42 McKnight-42 added the backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch label Oct 17, 2023
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
* add teardown_method for store_test_fail test

* create pr

* add teardown to delta test class as it also builds tests on alt schema

(cherry picked from commit 99c5c5a)
McKnight-42 added a commit that referenced this pull request Oct 24, 2023
* add teardown_method for store_test_fail test

* create pr

* add teardown to delta test class as it also builds tests on alt schema

(cherry picked from commit 99c5c5a)

Co-authored-by: Matthew McKnight <[email protected]>
colin-rogers-dbt pushed a commit that referenced this pull request Oct 24, 2023
* add teardown_method for store_test_fail test

* create pr

* add teardown to delta test class as it also builds tests on alt schema

(cherry picked from commit 99c5c5a)

Co-authored-by: Matthew McKnight <[email protected]>
colin-rogers-dbt pushed a commit that referenced this pull request Oct 24, 2023
* add teardown_method for store_test_fail test

* create pr

* add teardown to delta test class as it also builds tests on alt schema

(cherry picked from commit 99c5c5a)

Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants