Skip to content

Commit

Permalink
[review and merge in aug 2024] remove fal related resources (#5368)
Browse files Browse the repository at this point in the history
**Update**
We will review and merge this PR around Aug 2024 to give users time to
adjust to this adapter sunset. to ease the removal , we're going to:

- phase 1: add a callout that the dbt fal adapter isn't being
maintained/supported anymore. this helps set expectations for users.
- phase 2: fully merge THIS PR to remove the docs around aug 2024 time.

## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If related to an open 
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

Delete dbt-fal documentation because it has been archived

https://github.com/fal-ai/dbt-fal 

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [x] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [x] Add an entry for deleted pages in `website/vercel.json`
- [x] Run link testing locally with `npm run build` to update the links
that point to deleted pages

---------

Co-authored-by: Mirna Wong <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
  • Loading branch information
3 people authored Aug 12, 2024
1 parent f0218d1 commit 6575fbf
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 153 deletions.
14 changes: 0 additions & 14 deletions website/blog/maching-learning-dbt-baton-pass.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,20 +145,6 @@ This wouldn’t solve for the ML engineer and her desire to inject custom ML mod

It may be worth having python scripts live side by side dbt jobs and configurations. I can get better lineage and have one less tool to context switch to.

#### fal

- [fal](https://github.com/fal-ai/fal): Makes dbt and python interoperable. Read in a dbt model as a pandas dataframe using a [ref statement](https://github.com/fal-ai/fal/blob/b20874ab957f8eb0f65c56d82e6bb85c717de4c6/examples/write_jupyter_notebook.md#example-9-use-dbt-from-a-jupyter-notebook)!

#### How would this change my story?

**A ref statement would mean the same thing to both my ML engineer and me.**

We would work in the same dbt project for the entire workflow, not just part of it. We would align python scripts to dbt configurations for better lineage (see below).

![Screenshot of fal installation instructions](/img/blog/2022-02-18-machine-learning-dbt-baton-pass/fal-install-1.png)

![Second screenshot of fal installation instructions](/img/blog/2022-02-18-machine-learning-dbt-baton-pass/fal-install-2.png)

#### What are the tradeoffs of this tool path?

When things would go wrong, it’d still be a messy jumble to figure out how SQL changes inform python changes and vice versa. And I would need to care about which infrastructure my python code is running on. But my gut tells me the tradeoff would be worth it because there’d be less notebooks to schedule, and it’d be easier to align machine learning logic to dbt logic.
Expand Down
2 changes: 1 addition & 1 deletion website/dbt-versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,4 @@ exports.versionedCategories = [
"category": "Build your metrics",
"firstVersion": "1.6",
}
]
]
1 change: 0 additions & 1 deletion website/docs/docs/community-adapters.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Community adapters are adapter plugins contributed and maintained by members of
| ------------------------------------------ | -------------------------------- | ------------------------------------- |
| [Clickhouse](/docs/core/connect-data-platform/clickhouse-setup) | [Databend Cloud](/docs/core/connect-data-platform/databend-setup) | [Doris & SelectDB](/docs/core/connect-data-platform/doris-setup) |
| [DuckDB](/docs/core/connect-data-platform/duckdb-setup) | [Exasol Analytics](/docs/core/connect-data-platform/exasol-setup) | [Extrica](/docs/core/connect-data-platform/extrica-setup) |
| [fal - Python models](/docs/core/connect-data-platform/fal-setup) | [Firebolt](/docs/core/connect-data-platform/firebolt-setup) | [Greenplum](/docs/core/connect-data-platform/greenplum-setup) |
| [Hive](/docs/core/connect-data-platform/hive-setup) | [IBM DB2](/docs/core/connect-data-platform/ibmdb2-setup) | [Impala](/docs/core/connect-data-platform/impala-setup) |
| [Infer](/docs/core/connect-data-platform/infer-setup) | [iomete](/docs/core/connect-data-platform/iomete-setup) | [MindsDB](/docs/core/connect-data-platform/mindsdb-setup) |
| [MySQL](/docs/core/connect-data-platform/mysql-setup) | [RisingWave](/docs/core/connect-data-platform/risingwave-setup) | [Rockset](/docs/core/connect-data-platform/rockset-setup) |
Expand Down
51 changes: 0 additions & 51 deletions website/docs/docs/core/connect-data-platform/fal-setup.md

This file was deleted.

84 changes: 0 additions & 84 deletions website/docs/reference/resource-configs/fal-configs.md

This file was deleted.

2 changes: 0 additions & 2 deletions website/sidebars.js
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ const sidebarSettings = {
"docs/core/connect-data-platform/duckdb-setup",
"docs/core/connect-data-platform/exasol-setup",
"docs/core/connect-data-platform/extrica-setup",
"docs/core/connect-data-platform/fal-setup",
"docs/core/connect-data-platform/firebolt-setup",
"docs/core/connect-data-platform/greenplum-setup",
"docs/core/connect-data-platform/ibmdb2-setup",
Expand Down Expand Up @@ -834,7 +833,6 @@ const sidebarSettings = {
"reference/resource-configs/impala-configs",
"reference/resource-configs/clickhouse-configs",
"reference/resource-configs/doris-configs",
"reference/resource-configs/fal-configs",
"reference/resource-configs/firebolt-configs",
"reference/resource-configs/greenplum-configs",
"reference/resource-configs/infer-configs",
Expand Down
10 changes: 10 additions & 0 deletions website/vercel.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@
"cleanUrls": true,
"trailingSlash": false,
"redirects": [
{
"source": "/docs/core/connect-data-platform/fal-setup",
"destination": "https://github.com/fal-ai/dbt-fal",
"permanent": true
},
{
"source": "/reference/warehouse-setups/fal-setup",
"destination": "https://github.com/fal-ai/dbt-fal",
"permanent": true
},
{
"source": "docs/cloud/secure/environment-permissions",
"destination": "docs/cloud/manage-access/environment-permissions",
Expand Down

0 comments on commit 6575fbf

Please sign in to comment.