Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt Core and DuckDB Quickstart #4087

Closed
wants to merge 88 commits into from
Closed

dbt Core and DuckDB Quickstart #4087

wants to merge 88 commits into from

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Creating a dbt Core and DuckDB quickstart guide to get users up and running fast with a fully implemented dbt project

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

@matthewshaver matthewshaver requested a review from a team as a code owner September 18, 2023 17:54
@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 4:46pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Sep 18, 2023
@matthewshaver matthewshaver marked this pull request as draft September 19, 2023 14:43
@matthewshaver matthewshaver marked this pull request as ready for review October 18, 2023 22:04
@nghi-ly nghi-ly self-assigned this Oct 18, 2023
nghi-ly
nghi-ly reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! mostly nits around conciseness and another about reusing the Codespace content that we already have instead of repeating it

also, a new tile should be added this new qs. it's in the website/vercel.json file.

website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
website/docs/quickstarts/duckdb-core-qs.md Outdated Show resolved Hide resolved
@matthewshaver
Copy link
Contributor Author

Closing based on conversations around Jaffle Shop and Quickstart changes in the future

@dbeatty10 dbeatty10 mentioned this pull request Dec 10, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly left review comments

@greg-mckeon greg-mckeon Awaiting requested review from greg-mckeon

Assignees

@nghi-ly nghi-ly

Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @nghi-ly