Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configurable delimiters #4265

Merged
merged 34 commits into from
Oct 13, 2023
Merged

Adding configurable delimiters #4265

merged 34 commits into from
Oct 13, 2023

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Oct 12, 2023

Closes #4126
Closes #4273

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@runleonarun runleonarun requested a review from a team as a code owner October 12, 2023 04:29
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 11:28pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Oct 12, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 12, 2023
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the examples are a bit mixed up, added some suggested changes!

@runleonarun
Copy link
Collaborator Author

@graciegoheen I'm going to go ahead and merge this. Let me know if you want me to follow-up with other changes.

@runleonarun runleonarun enabled auto-merge (squash) October 13, 2023 23:25
@runleonarun runleonarun merged commit 82bc1df into current Oct 13, 2023
6 checks passed
@runleonarun runleonarun deleted the delimiter-adding branch October 13, 2023 23:28
@graciegoheen
Copy link
Collaborator

It looks FANTASTIC!! Thanks so much

@salimmoulouel
Copy link

salimmoulouel commented Feb 23, 2024

Hello, I tried with this configuration and it doesn't accept my delimiter, I have all the fields as a global field

properties.yml

version: 2

seeds:
  - name: test_delimiter
    config:
      delimiter: "|"
test_delimiter.csv
col_a|col_b|col_c
1|2|3
4|5|6

the resut i have is

Runtime Error in seed test_delimiter (seeds/seed_delimiter/test_delimiter.csv)
  Error while reading data, error message: CSV processing encountered too many errors, giving up. Rows: 0; errors: 2; max bad: 0; error percent: 0
  Error while reading data, error message: CSV table references column position 2, but line contains only 1 columns.; line_number: 2 byte_offset_to_start_of_line: 18 column_index: 2 column_name: "col_c" column_type: INT64
  Error while reading data, error message: CSV table references column position 2, but line contains only 1 columns.; line_number: 3 byte_offset_to_start_of_line: 24 column_index: 2 column_name: "col_c" column_type: INT64
  You are loading data without specifying data format, data will be treated as CSV format by default. If this is not what you mean, please specify data format by --source_format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update migration guide to link to new pages Update seed configs to include delimiter from dbt-core PR #7186
5 participants