Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New databricks oauth #4269

Merged
merged 17 commits into from
Oct 13, 2023
Merged

New databricks oauth #4269

merged 17 commits into from
Oct 13, 2023

Conversation

Fleid
Copy link
Contributor

@Fleid Fleid commented Oct 12, 2023

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@Fleid Fleid requested a review from a team as a code owner October 12, 2023 14:51
@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 3:32pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Oct 12, 2023
runleonarun
runleonarun reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fleid This looks great! I left some light edits. We may want to change bullets to steps but I don't think we need to do that now.

website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/manage-access/set-up-databricks-oauth.md Outdated Show resolved Hide resolved
runleonarun
runleonarun reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nghi-ly and @Fleid this LGTM and ready to 🚢 !

runleonarun
runleonarun approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nghi-ly nghi-ly merged commit 34f8b50 into current Oct 13, 2023
3 checks passed
@nghi-ly nghi-ly deleted the new-databricks-oauth branch October 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fleid @runleonarun @nghi-ly