Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dimension name #4272

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix dimension name #4272

merged 3 commits into from
Oct 16, 2023

Conversation

dpguthrie
Copy link
Contributor

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@dpguthrie dpguthrie requested a review from a team as a code owner October 12, 2023 16:45
@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 3:23pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 12, 2023
mirnawong1
mirnawong1 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dpguthrie , this looks good but not sure what's the change? it looks the same -- unless it's the underscore

@mirnawong1 mirnawong1 enabled auto-merge October 13, 2023 10:11
@dpguthrie
Copy link
Contributor Author

hey @dpguthrie , this looks good but not sure what's the change? it looks the same -- unless it's the underscore

Ya, it's just the missing underscore.

@mirnawong1 mirnawong1 merged commit 5c9c4b9 into current Oct 16, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the dpguthrie-patch-2 branch October 16, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpguthrie @mirnawong1 @matthewshaver