Splitting tabs up #4302
Merged
Splitting tabs up #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
2 tasks
nghi-ly
reviewed
Oct 18, 2023
There was a problem hiding this comment.
looks good! since you're editing this page, suggest updating the placeholder text to follow the style guide guidelines https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md#Placeholder-text
dbeatty10
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
This looks awesome @matthewshaver !
Makes it much easier to see the different options (and hyperlink to them) without the tabs.
github-actions
bot
added
size: medium
matthewshaver
commented
Oct 19, 2023
nghi-ly
reviewed
Oct 19, 2023
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Co-authored-by: Ly Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
What are you changing in this pull request and why?
Splitting up tabs into separate examples to simplify discovery. See feedback on #3121
Checklist