-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stoplight css #4350
Update stoplight css #4350
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f901bba
to
2a532c9
Compare
2a532c9
to
c99be20
Compare
c99be20
to
c365a15
Compare
c365a15
to
915a827
Compare
3faad9e
to
a0ad50d
Compare
@GideonShils I'm still seeing missing bullet points. For example here: And missing steps as shown in the quickstarts. |
website/docusaurus.config.js
Outdated
"/css/redoc.css", | ||
"/css/stoplight-base.css", | ||
"/css/stoplight-custom.css", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GideonShils, when the css files are added within the docusaurus config, it will add them to every page throughout the site. For example, I see styles from stoplight-base.css
being applied on the homepage.
Most are overridden by custom styles, but it might be difficult to promise styles on all pages are not affected.
Rather than adding them here in the config, would it be possible to add the css files directly in the src/pages/dbt-cloud/api*
files to make them only available on those pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up removing the css files from the docusaurus config and imported them directly in the stoplight component. I kept them as separate stylesheets as opposed to CSS modules so that they would only load on the API docs pages and not on the rest of the site. Tested to ensure:
- New styles do not load on rest of site: headings look correct, bullet points appear as expected
- Styles load on new pages: nav bar has correct font, content has correct custom styles
93ecc71
to
4bb2820
Compare
4bb2820
to
db35385
Compare
db35385
to
93070f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! verified stoplight styles being picked up on the api pages, while not being applied to other pages on the site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GideonShils! This looks good to me. I love that the examples are working, I think it's a known issue that the Send API request is still not working, but all fonts and the rest of the site look good.
The one tiny nit I found was the API calls are also hard to read in dark mode. But [perhaps something for another day.
What are you changing in this pull request and why?
A few CSS fixes for our stoplight based API docs:
Updated sidepanel fonts:
Updated content fonts / codeblock colors:
Checklist