Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about Snowflake using Dynamic Tables instead of Materialized Views #4375

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add note about Snowflake using Dynamic Tables instead of Materialized Views #4375

merged 3 commits into from
Oct 31, 2023

Conversation

mikkosulonen
Copy link
Contributor

What are you changing in this pull request and why?

Materialized view documentation page lacks any information that the implementation differs for one of the major adapters: Snowflake. It is mentioned in the Snowflake specific configs though.

So just adding a link in the Materialized View docs pointing to Snowflake configs.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@mikkosulonen mikkosulonen requested a review from a team as a code owner October 31, 2023 14:44
@welcome Welcome
Copy link

welcome bot commented Oct 31, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 3:30pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 31, 2023
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 31, 2023
mirnawong1
mirnawong1 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mikkosulonen ! great flag and thanks for opening this pr to clarify that! I'll get this merged for you and appreciate you improving this section ✨

@mirnawong1 mirnawong1 enabled auto-merge October 31, 2023 15:17
@mirnawong1 mirnawong1 merged commit 33394ea into dbt-labs:current Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkosulonen @mirnawong1 @runleonarun