Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typos in saved queries docs #4471

Conversation

antoineroncoroni-electra

What are you changing in this pull request and why?

Fixed small typos in saved queries docs (here):

  • saved_queries instead of saved_query
  • group_by instead of group_bys

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@antoineroncoroni-electra antoineroncoroni-electra requested a review from a team as a code owner November 15, 2023 11:25
Copy link

welcome bot commented Nov 15, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 5:02pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Nov 15, 2023
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Nov 15, 2023
@mirnawong1
Copy link
Contributor

hey @antoineroncoroni-electra thanks for opening this pr up and great contribution! I'm investigating this on my end and will revert back for more updates. i think you're def right about group_by being incorrect. i just need to verify the saved_query change.

@mirnawong1
Copy link
Contributor

hey @antoineroncoroni-electra ! we merged a pr #4473 that addresses this so i'll close your pr since they're the same. thank you so much for flagging this and opening it up -- looking forward to your future contributions ✨ https://docs.getdbt.com/docs/build/saved-queries

@mirnawong1 mirnawong1 closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants