Add cache action to lint workflow #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: x-small
github-actions
bot
added
size: small
JKarlavige
commented
Nov 20, 2023
There was a problem hiding this comment.
This was in the root and was likely added by accident by running npm i in the root.
JKarlavige
requested review from
a team,
breezyfasano and
john-rock
and removed request for
a team
john-rock
approved these changes
Nov 21, 2023
Yeah that's correct, the line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Adds caching to
lintworkflow to attempt to reduce bandwidth usage in Vercel. This also speeds up the workflow checks for Docs PRs as it no longer needs to wait to install all packages on each run.Initial run where node mods was cached (Under
Post Cache Node Modules)https://github.com/dbt-labs/docs.getdbt.com/actions/runs/6936641309/job/18869155154
2nd run where
lintworkflow detects and uses cache (UnderCache Node Modules)https://github.com/dbt-labs/docs.getdbt.com/actions/runs/6936659386/job/18869211562
Ensure site is not nuked:
https://docs-getdbt-com-git-cache-node-mods-ci-dbt-labs.vercel.app/