Update dynamic table configuration for Snowflake #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mikealfare
changed the title
dbeatty10
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Things look good in the preview 👍
I didn't verify the code examples or the key technical details.
My main feedback is that:
- it would be nice to make the table less wide
- consider lowercase or sentence case for
YES/NO, and potentially others
These are nits, and I'm checking off the "Review by DX" box.
Co-authored-by: Doug Beatty <[email protected]>
dbeatty10
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
I'm updating the configuration documentation for dynamic tables in
dbt-snowflake. We didn't initially support swapping dynamic tables with non-dynamic tables (e.g. table, view, etc.) in 1.6. We now support that for 1.7. While making these updates, I also implemented a structure that aligns with the structure I used fordbt-bigquery. I will be submitting another PR for thedbt-redshiftanddbt-postgreschanges that will align with this structure as well.Checklist