Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 1.8 install changes #5002

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Adding 1.8 install changes #5002

merged 10 commits into from
Feb 28, 2024

Conversation

runleonarun
Copy link
Collaborator

closes #4999

What are you changing in this pull request and why?

Updating adapter and core install content for v1.8. You now need to explicitly install core and the adapter as they have been decoupled.

@runleonarun runleonarun requested a review from a team as a code owner February 28, 2024 01:20
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 6:51pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Feb 28, 2024
@runleonarun runleonarun changed the title adding install changes Adding 1.8 install changes Feb 28, 2024
@runleonarun @colin-rogers-dbt
Rewording to be more specific
ac9737b 
Co-authored-by: colin-rogers-dbt <[email protected]>
mirnawong1
mirnawong1 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ready and it lgtm, however added some suggestions for you to review!

also, do you think we need to update the core setup pages example here as well? the snippet for that page is found here

@runleonarun runleonarun merged commit 3dd2933 into current Feb 28, 2024
7 checks passed
@runleonarun runleonarun deleted the 1.8install-updates branch February 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt left review comments

@dbeatty10 dbeatty10 dbeatty10 left review comments

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@graciegoheen graciegoheen graciegoheen approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update adapter and core install content for v1.8
5 participants
@runleonarun @dbeatty10 @graciegoheen @mirnawong1 @colin-rogers-dbt