-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix store_failures
schema documentation
#5047
Conversation
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey, I see there's a conflict here, do I need to take some action? |
@@ -10,7 +10,7 @@ Optionally set a test to always or never store its failures in the database. | |||
- If specified as `true` or `false`, the | |||
`store_failures` config will take precedence over the presence or absence of the `--store-failures` flag. | |||
- If the `store_failures` config is `none` or omitted, the resource will use the value of the `--store-failures` flag. | |||
- When true, `store_failures` save all the record(s) that failed the test only if [limit](/reference/resource-configs/limit) is not set or if there are fewer records than the limit. `store_failures` are saved in a new table with the name of the test. By default, `store_failures` use a schema named `dbt_test__audit`, but, you can [configure](/reference/resource-configs/schema#tests) the schema to a different value. | |||
- When true, `store_failures` saves all records (up to [limit](/reference/resource-configs/limit)) that failed the test. Failures are saved in a new table with the name of the test. By default, `store_failures` uses the schema `{{ profile.schema }}_dbt_test__audit`, but you can [configure](/reference/resource-configs/schema#tests) the schema suffix to a different value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @brunokim,
Thanks for flagging this. This looks really good. I have no changes or suggestions on my end. I'll also look at the merge conflict for you.
Kind Regards
Natalie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @brunokim and @nataliefiann , fixed up the merge conflict!
|
||
<File name='dbt_project.yml'> | ||
|
||
```yml | ||
tests: | ||
+store_failures: true | ||
+schema: the_island_of_misfit_tests | ||
+schema: _sad_test_failures # Will write tables to my_database.my_schema__sad_test_failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you changing in this pull request and why?
I'm documenting how the config
tests.schema
is currently used. It does not define the schema where to store test failures, but the schema suffix appended to the configured profile schema.I discovered this via trial-and-error, there may be other edge cases I haven't considered.
Checklist