Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revising and condensing definitions #5067

Merged
merged 19 commits into from
Mar 19, 2024
Merged

revising and condensing definitions #5067

merged 19 commits into from
Mar 19, 2024

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Mar 13, 2024

Closes #5062
Closes #3403

What are you changing in this pull request and why?

Revising the definitions and then makign a reusable to place them on two pages.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@runleonarun runleonarun requested a review from a team as a code owner March 13, 2024 02:01
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 1:12am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Mar 13, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking real good! ✨ mostly minor nits

curious, what do you think about wrapping the green circled text in a tip callout and, for the orange circled text, using a table instead? totally non-blocking

Screenshot 2024-03-15 at 2 27 58 PM

website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
website/snippets/_indirect-selection-definitions.md Outdated Show resolved Hide resolved
@runleonarun
Copy link
Collaborator Author

@matthewshaver this is from doug about the image. Can you fix the image website/static/img/docs/reference/indirect-selection-dbt-run.png ?

dbt run doesn't include tests, so this would need to say dbt build like the other images instead of dbt run.

And the file should probably be renamed accordingly as well.

@runleonarun
Copy link
Collaborator Author

@matthewshaver Here are my latest changes

Can you give this a final 👀 and merge it if it's good? Note:

  • Didn't add a table just for lack of time. We can do that next time we're in this code if we want. I do like the idea. I did want to check if google searches easily search tables. I assume so.

@matthewshaver matthewshaver merged commit 79d24e6 into current Mar 19, 2024
7 checks passed
@matthewshaver matthewshaver deleted the indirect-sel-modes branch March 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better explanation of indirect selection modes Add diagram(s) to explain different indirect selection modes
4 participants