-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify statement blocks macro need ref #5138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
size: small
This change will take 1 to 2 days to address
labels
Mar 22, 2024
mirnawong1
commented
Mar 25, 2024
joellabes
requested changes
Mar 27, 2024
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
thanks so much @joellabes ! folded in you suggs and the preview looks good i think! |
if you're ok with it, will merge it this week! |
joellabes
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto update
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
size: small
This change will take 1 to 2 days to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tonayya raised that the example code for statement blocks here doesn't actually work. We should fix this up so users don't get confused:
So if you actually run this:
{%- call statement('states', fetch_result=True) -%}
{%- endcall -%}
dbt won't know how to resolve the reference so it needs to be specified somewhere. So this can either be done using -- depends_on or doing a ref() function outside the statement block:
Option A:
-- depends_on: {{ ref('abc') }}
{% call statement('st') %}
{% endcall %}
select 2 as id
Option B:
{%- call statement('st') -%}
{%- endcall -%}
select id * 2 as id from {{ ref('abc') }}
Resolves #5087