Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entities.md #5216

Merged
merged 23 commits into from
Aug 29, 2024
Merged

Update entities.md #5216

merged 23 commits into from
Aug 29, 2024

Conversation

ialdg
Copy link
Contributor

@ialdg ialdg commented Apr 3, 2024

Hi.
This modification proposal adds a comment to the Unique bulletpoint suggesting the addition of examples to differentiate between Primary and Unique. Regards.
IL.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Hi.
This modification proposal adds a comment to the Unique bulletpoint suggesting the addition of examples to differentiate between Primary and Unique.
Regards.
IL.
@ialdg ialdg requested a review from a team as a code owner April 3, 2024 12:24
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) 💬 Add feedback Aug 29, 2024 9:46am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Apr 3, 2024
@mirnawong1 mirnawong1 self-assigned this Apr 5, 2024
Copy link

vercel bot commented Jul 25, 2024

@mirnawong1 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: x-small This change will take under 3 hours to fix. labels Jul 25, 2024
@mirnawong1
Copy link
Contributor

Asked Pm for review

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again for your patience and opening this up @ialdg ! I've made some changes to add examples and make it clearer. as always, we appreciate your amazing contribution and feedback again!

@mirnawong1 mirnawong1 enabled auto-merge (squash) August 29, 2024 09:43
@mirnawong1 mirnawong1 merged commit 10a3c57 into dbt-labs:current Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants