Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #5303

Merged
merged 11 commits into from
Apr 26, 2024
Merged

Next #5303

merged 11 commits into from
Apr 26, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Merge current into next

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 6:55pm

@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Apr 18, 2024
@matthewshaver matthewshaver requested a review from a team as a code owner April 18, 2024 03:47
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: x-small This change will take under 3 hours to fix. labels Apr 18, 2024
@mirnawong1
Copy link
Contributor

mirnawong1 commented Apr 26, 2024

hey @matthewshaver , great job and thanks so much for consolidating this! I've got some feedback on the layout:

  • structure — maybe we can have a more consistent, clean layout that makes it easy to distinguish between different types of updates (new features, enhancements, fixes). i think if we use headers and subheaders, it might allow us to bulk related topics inside the header (e.g. all the 'new' goes under the ## new header, etc. i also wonder if we can consider adding icons or colo to visually separate different sections?
  • expandable — maybe we can indent the expandable so its in line with the bullets. currently it's looking all weird. i also wonder if we can have the expendables grouped grouped together so it doesn't interrupt the bullet bullet bullet,etc flow?
  • right toc — might be good to have a right toc so users can quickly navigate?
  • intro — nice-to-have a more fleshed-out intro sentence?

example

April 2024

What’s new:

  • Merge jobs [Beta] - Trigger dbt job runs via Git pull requests....
  • Semantic Layer enhancements - Additional support for Privatelink and SSO....

Enhancements:

  • Select entities for group by, filter by, and order by in Semantic Layer...,

Fixes:

  • Resolved dbt parse error when using list filters.
  • Improved join_to_timespine application in metrics.

@mirnawong1
Copy link
Contributor

also adding replicated's docs as inspo: https://docs.replicated.com/release-notes/rn-app-manager

@matthewshaver
Copy link
Contributor Author

matthewshaver commented Apr 26, 2024

@mirnawong1 Great feedback and good ideas worth considering. We currently have an Asana task open to fix the formatting errors for the lifecycle pills so we can use those in front of the items.

As for the grouping, we need to take into consideration that these will be grouped by week once we go live (based on customer requests for release notes). We've taken the historical data and grouped it by Month but when we go live it will look more like this:

MONTH

WEEK 1

  • New: Feature
  • Fix: Feature
  • Enhancement: Feature

WEEK 2

  • New: Feature
  • Fix: Feature
  • Enhancement: Feature

and so on

Let's bring it to the group when I get back and figure out what we think is the best way to group in that context.

Right TOC - will be adding that, but the automation removes it from that section, so we have to figure out a way to put it back. If you have ideas, I'm open to them.

Intro - it's a pretty straightforward section, so I kept it simple, but I'm open to any additional language you think would be good.

Expandables - I'll try the indenting and see what that looks like now! Great idea. I also have an Asana task in to get those to support markdown formatting in the title

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver small suggestion for right ToC


dbt Cloud release notes for 2024.

# April 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver If you change these to an H2 they show up in the right hand TOC!

Suggested change
# April 2024
## April 2024

@runleonarun
Copy link
Collaborator

@mirnawong1 and @matthewshaver I added some thoughts about layout in the follow-up issue

Quick question: when will we remove the old jan through April folders and add redirects?

@matthewshaver
Copy link
Contributor Author

@mirnawong1 and @matthewshaver I added some thoughts about layout in the follow-up issue

Quick question: when will we remove the old jan through April folders and add redirects?

Yup! I'll work on it when I get back!

@matthewshaver matthewshaver merged commit dd7631d into current Apr 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants