Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging environment adds #5356

Merged
merged 10 commits into from
May 1, 2024
Merged

Staging environment adds #5356

merged 10 commits into from
May 1, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding additional information about Staging environments as outlined here

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner April 25, 2024 02:10
@matthewshaver matthewshaver requested review from jtcohen6 and removed request for a team April 25, 2024 02:10
@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 11:12pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address and removed Docs team Authored by the Docs team @dbt Labs labels Apr 25, 2024
matthewshaver
matthewshaver commented Apr 25, 2024
View reviewed changes
website/docs/docs/cloud/about-cloud-develop-defer.md
Copy link
Contributor Author

@matthewshaver matthewshaver Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 32/34 "To enable defer in the dbt Cloud IDE, toggle the Defer to production button on the command bar. Once enabled, dbt Cloud will:"

Does this workflow change? How is the behavior different when that toggle is selected if at all?

@matthewshaver
Copy link
Contributor Author

@jtcohen6 Feel free to make any suggested changes or additions to the language and I'll pass to my team for editorial review after.

@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Apr 25, 2024
@matthewshaver matthewshaver requested a review from a team April 25, 2024 15:41
jtcohen6
jtcohen6 reviewed May 1, 2024
View reviewed changes
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewshaver @runleonarun!

I left one "highest priority" comment. The rest are smaller corrections or suggestions for clarity.

Reviewing our original docs plan - I think we should also add notes to the top of these two older dev blog posts, indicating that they were written before the advent of Staging environments, which further improve how dbt Cloud can support the patterns discussed, and link back to those docs:

website/docs/docs/cloud/about-cloud-develop-defer.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/explore-projects.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/govern/project-dependencies.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/deploy-environments.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/govern/project-dependencies.md Show resolved Hide resolved
@runleonarun runleonarun mentioned this pull request May 1, 2024
Open
1 task
@runleonarun
Copy link
Collaborator

528dd5d

Added notes in blog posts!

runleonarun
runleonarun approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to ship! Thanks for your feedback @jtcohen6.

@runleonarun runleonarun merged commit 2c08d72 into current May 1, 2024
11 checks passed
@runleonarun runleonarun deleted the staging-adds branch May 1, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 left review comments

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewshaver @runleonarun @jtcohen6